Conversation
Extracting the polling into hooks/useMaintenanceStatus (94c8a6f) left the layout calling the store's useFetchMaintenanceStatus selector, which only returns the fetch function. The frontend has not requested /maintenance/status since, so the maintenance banner and the maintenance-aware buttons never activated.
✅ Deploy Preview for vrtx-dashboard canceled.
|
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The frontend has not fetched
/v1/maintenance/statussince 94c8a6f (2026-02-03). That commit moved the polling effect out ofBaseLayoutintohooks/useMaintenanceStatus.ts, but the layout ended up calling the store'suseFetchMaintenanceStatus()selector, which only returns the fetch function and never invokes it. As a resultMaintenanceBannernever rendered anduseMaintenanceAwareButtonnever disabled the quote/KYC submit buttons during scheduled maintenance.Change
BaseLayoutcalls the existing polling hook (useMaintenanceStatus: fetch on mount, refresh every 5 minutes), restoring the pre-February behaviour.src/layouts/index.test.tsxrenders the layout with the real store and banner against an MSW-served active maintenance window and asserts the banner appears. It fails onstagingand passes with the fix.Rollout note
Once deployed, any maintenance schedule that is currently marked active in the API will immediately show the banner and disable ramp submit buttons. Check there is no stale active schedule before releasing.
Verification
apps/frontend:tsc --noEmitclean,bun run test191/191 (190 existing + 1 new),bun run build(incl. prerender) succeedsbun run verify(Biome) clean