Repository navigation
keep whether agents' feedback has been handled, and how - #164
Merged
Merged
Conversation
- AgentFeedback: resolvedAt, when we marked it handled, and resolution, a short note on how, such as the pull request that fixed it; both null while it is open. Written from our admin, nothing here writes them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents' feedback (
send_feedbackand the agent pages' form) piles up with no way to tell what we have already handled. This adds two nullable columns toAgentFeedback:resolvedAt, when we marked it done, andresolution, a short note on how, such as the pull request that fixed it (#151) orupstream. Both are null while it is open, which is every existing row after the migration (v038_add_agent_feedback_resolution).Nothing in this repo reads or writes them: the app never shows feedback, and saving it leaves both null. Our admin marks feedback done and opens it again; that change is in the internal repo's pull request, which points its
proxy/at this branch until this merges: personalagentproxy/internal#21 (private).Testing
bun run typecheck,bun run test(the migration-name test included)prisma migrate difffrom the schema before to the schema after prints the sameALTER TABLEprisma migrate deployapplied every migration through v038, andprisma migrate difffrom that database to the schema was empty