Repository navigation
grey out google in the catalog when the server has no google client - #84
Merged
Merged
Conversation
hkonsti
force-pushed
the
hkonsti/google-5-unconfigured
branch
from
October 13, 2026 21:36
2ac062e to
73badbc
Compare
hkonsti
force-pushed
the
hkonsti/google-5-unconfigured
branch
2 times, most recently
from
October 14, 2026 17:29
9788ba5 to
6b04310
Compare
hkonsti
force-pushed
the
hkonsti/google-5-unconfigured
branch
from
October 14, 2026 18:14
6b04310 to
57161f3
Compare
…and say why when its sign-in can't start
… start route checks it, and drop a stale unconfigured error once the server has the client
hkonsti
force-pushed
the
hkonsti/google-5-unconfigured
branch
from
October 15, 2026 00:20
57161f3 to
63f870b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The catalog now greys out an integration whose need the server doesn't meet, with a hint naming the environment variables and linking the docs; for now that is Google without
GOOGLE_CLIENT_IDandGOOGLE_CLIENT_SECRET. The web'sIntegrationgets aneedsmarker, and the add-connection and welcome loaders fetch/auth/methodsbeside the connections, since Google sign-in and Google connections share the client. A sign-in started anyway (by URL) now comes back with?error=google-unconfigured, which the catalog shows as the same sentence, while?error=googlestays for a sign-in that failed.Stack: self-hoster surface 2 of 2, on #83.
Open workspace in Conductor