Skip to content

fix(bdweb): bind to 127.0.0.1 by default - #258

Closed
HarshRajSinghania wants to merge 2 commits into
petercorke:feat/bdwebfrom
HarshRajSinghania:fix/bdweb-localhost-default
Closed

HarshRajSinghania wants to merge 2 commits into
petercorke:feat/bdwebfrom
HarshRajSinghania:fix/bdweb-localhost-default

Conversation

@HarshRajSinghania

Copy link
Copy Markdown

Fixes #218 by defaulting the bdweb server to 127.0.0.1 and adding a --host flag.

Summary: Changes default bind address from 0.0.0.0 to loopback. Adds --host argument. Updates README security note and usage.

Testing: Added and ran unit tests that mock uvicorn.run to confirm default and override.

Fixes #218

Harsh Raj Singhania added 2 commits November 15, 2026 22:13
Default host is now loopback; add --host flag for explicit network exposure.
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for the pull request. The issue it addresses (#218) is not assigned to HarshRajSinghania. bdsim asks contributors to comment on the issue to ask to be assigned, and to wait for a maintainer before opening a pull request (see CONTRIBUTING.md). A pull request for an issue that is not assigned to its author may be closed without review.

This check runs again when the description is edited or a label changes, and a maintainer can run it again once the issue is assigned.

@github-actions github-actions Bot added the needs-assignment The PR's author is not assigned to the issue it addresses (see CONTRIBUTING.md) label Nov 15, 2026
@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@petercorke

Copy link
Copy Markdown
Owner

Thank you for your interest in bdsim, @HarshRajSinghania, and for the patch. I'm closing this for now rather than merging it, for process reasons: #218 isn't assigned to you (CONTRIBUTING asks contributors to comment on the issue, say how they use bdsim, and wait to be assigned), and two other people had already asked about it. The description also mentions unit tests, but the diff contains only README.md and __main__.py. If you'd still like to take #218, please comment there saying how you use bdsim. If you're assigned, send the PR again against feat/bdweb with the tests included. Thanks again for the contribution.

@petercorke petercorke closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-assignment The PR's author is not assigned to the issue it addresses (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants