Repository navigation
fix(bdweb): bind to 127.0.0.1 by default - #258
HarshRajSinghania wants to merge 2 commits into
Conversation
Default host is now loopback; add --host flag for explicit network exposure.
|
Thank you for the pull request. The issue it addresses (#218) is not assigned to This check runs again when the description is edited or a label changes, and a maintainer can run it again once the issue is assigned. |
Not up to standards ⛔
|
|
Thank you for your interest in bdsim, @HarshRajSinghania, and for the patch. I'm closing this for now rather than merging it, for process reasons: #218 isn't assigned to you (CONTRIBUTING asks contributors to comment on the issue, say how they use bdsim, and wait to be assigned), and two other people had already asked about it. The description also mentions unit tests, but the diff contains only |
Fixes #218 by defaulting the bdweb server to 127.0.0.1 and adding a --host flag.
Summary: Changes default bind address from 0.0.0.0 to loopback. Adds --host argument. Updates README security note and usage.
Testing: Added and ran unit tests that mock uvicorn.run to confirm default and override.
Fixes #218