Repository navigation
fix(bdweb): hide deprecated blocks from the palette - #267
Open
KristofersJurevics wants to merge 1 commit into
Open
KristofersJurevics wants to merge 1 commit into
KristofersJurevics wants to merge 1 commit into
Conversation
Not up to standards ⛔
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The web palette and block-info endpoint expose deprecated blocks from the private registry. Use
sim.block_libraryfor both endpoints so users can selectINTEGRATOR_Sinstead ofDINTEGRATOR.This changes public behaviour: deprecated block types disappear from
/api/blocksand return 404 from/api/blockinfo/{name}. Existing diagrams containing those types still load.Fixes #220. Targets
feat/bdweb, as requested.Testing
On Python 3.10 with
MPLBACKEND=Agg QT_QPA_PLATFORM=offscreen:pytest tests/test_bdweb.py -q --timeout=50 --timeout_method=thread: 50 passed.pytest --capture=no --timeout=50 --timeout_method=thread: 525 passed, 9 skipped.git diff --checkpassed. The branch's server file has pre-existing whole-file Black differences, which are left alone.OpenAI Codex drafted the fix and regression tests and ran the commands above. The contributor has confirmed personally reading, running and understanding the change.
Checklist