Repository navigation
test: broaden BundleAdjust and pgraph scene-graph coverage - #130
Merged
Merged
Conversation
Cover graph structure (vertex/edge counts, endpoints, names, observations, back-references, connectivity), state vector bookkeeping, a three-view optimization, __str__/__repr__, plot() and the SBA file loader. Run against both pgraph 0.6.x and 1.0. Remove tests/test_bundle_adjust.py: byte-identical to test_visual_servo.py and nothing to do with bundle adjustment. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 34 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the fix PR for fixed landmarks (base is that branch so the diff is just the tests; GitHub retargets to
mainwhen it merges).What
Went from 2 BundleAdjust tests to 17: scene-graph structure (vertex/edge counts, endpoints, names, observation values, back-references, connectivity), state vector bookkeeping and fixed-view handling, a three-view optimization,
__str__/__repr__,plot(), and the SBA file loader (round trip via a synthetic file set).Removes
tests/test_bundle_adjust.py: byte-identical totest_visual_servo.pyand unrelated to bundle adjustment.Testing
All pass against pgraph 0.6.4 and 1.0.0.
Note for review:
optimize()returns the new state vector but does not write it back to the graph (callers usesetstate()); the test pins that current behaviour.🤖 Generated with Claude Code