Skip to content

test: broaden BundleAdjust and pgraph scene-graph coverage - #130

Merged
petercorke merged 2 commits into
mainfrom
test/bundleadjust-coverage
Oct 13, 2026
Merged

petercorke merged 2 commits into
mainfrom
test/bundleadjust-coverage

Conversation

@petercorke

Copy link
Copy Markdown
Owner

Stacked on the fix PR for fixed landmarks (base is that branch so the diff is just the tests; GitHub retargets to main when it merges).

What

Went from 2 BundleAdjust tests to 17: scene-graph structure (vertex/edge counts, endpoints, names, observation values, back-references, connectivity), state vector bookkeeping and fixed-view handling, a three-view optimization, __str__/__repr__, plot(), and the SBA file loader (round trip via a synthetic file set).

Removes tests/test_bundle_adjust.py: byte-identical to test_visual_servo.py and unrelated to bundle adjustment.

Testing

All pass against pgraph 0.6.4 and 1.0.0.

Note for review: optimize() returns the new state vector but does not write it back to the graph (callers use setstate()); the test pins that current behaviour.

🤖 Generated with Claude Code

Cover graph structure (vertex/edge counts, endpoints, names, observations,
back-references, connectivity), state vector bookkeeping, a three-view
optimization, __str__/__repr__, plot() and the SBA file loader.  Run
against both pgraph 0.6.x and 1.0.

Remove tests/test_bundle_adjust.py: byte-identical to test_visual_servo.py
and nothing to do with bundle adjustment.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codacy-production

codacy-production Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 34 complexity · 0 duplication

Metric Results
Complexity 34
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Base automatically changed from fix/bundleadjust-pgraph-compat to main October 13, 2026 02:38
@petercorke
petercorke merged commit 34a730a into main Oct 13, 2026
35 checks passed
@petercorke
petercorke deleted the test/bundleadjust-coverage branch October 13, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant