Repository navigation
fix: JupyterLite bootstrap installs the bundled wheel, using the shared template - #180
Merged
Merged
Conversation
…ed template The bootstrap globbed /pypi, which does not exist in the kernel, so it always installed the last PyPI release. It is now the rvc-ecosystem template with MVTB's constants: it installs through piplite, so the toolbox is the wheel built with the site, and it tells the reader to wait while it installs. spatialmath-python>=1.1.19 no longer lists pre-commit as a runtime dependency, so the deps=False workaround for it goes. Refs #160, #172, #137 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Replaces the local .githooks/pre-commit, sync_bootstrap.py and clear_outputs.py, and the tests of them, with the shared hooks, as bdsim does. The shared clear_outputs.py clears every dirty cell, not only the first (the any() over a generator), which is the first part of #157. CI runs the hooks instead of the two --check commands. Refs #157 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Outputs cleared, the same kernel in every notebook, written as nbformat writes them, and the logo in the first cell given a height and style="height:auto" so that Colab and a narrow pane do not squash it. Dropped the editor's toc and varInspector entries and Colab's own colab and accelerator entries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The bootstrap no longer installs from a pypi/ path, so the redirect never matched and the check installed the last PyPI release. Redirect the install of the toolbox itself to the mounted wheel. Refs #157 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 23 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
The shared template reports the package name, not MVTB. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts rvc-ecosystem's notebook tooling, so MVTB, RTB and bdsim install the same way.
_mvtb_nb_bootstrap.pyis now the canonical template with MVTB's constants. It installs throughpiplite, so JupyterLite gets the wheel built with the site rather than the last PyPI release, and it tells the reader to wait while it installs. Refs JupyterLite bootstrap never uses the bundled wheel: /pypi does not exist in the kernel, so it installs the last PyPI release #160, Notebook bootstrap cell: tell the reader to wait while it installs (follow bdsim#270) #172.spatialmath-python>=1.1.19, so thedeps=Falseworkaround for it goes. Refs Revert JupyterLite deps=False workaround once spatialmath #250 is released (review by 2026-10-28) #137..githooks,sync_bootstrap.pyandclear_outputs.pyare replaced by rvc-ecosystem's pre-commit hooks, which CI now runs. The sharedclear_outputs.pyclears every dirty cell, not just the first. Refs Notebook tooling: clear_outputs.py stops at the first dirty cell, wasm_check does not test the built wheel #157.toc/varInspectorand Colab'scolab/acceleratormetadata.Tested: pre-commit hooks pass; the Node/Pyodide install check passes with the built wheel.
🤖 Generated with Claude Code