Repository navigation
fix: say why an OpenCV contrib module is missing - #182
Merged
Merged
Conversation
Pyodide, and so JupyterLite, has plain OpenCV without ximgproc, xfeatures2d and the other contrib modules, so using one failed with a bare AttributeError. A stand-in for each missing module now raises an AttributeError that names the module and says it needs opencv-contrib-python. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 17 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pyodide, and so JupyterLite, ships plain OpenCV without the contrib modules (
ximgproc,xfeatures2dand others), so using one failed with a bareAttributeError: module 'cv2' has no attribute 'ximgproc'. On import, MVTB now puts a stand-in for each missing contrib module intocv2. Using it raises anAttributeErrorsubclass that says the contrib modules are not installed, how to install them on a desktop (pip install opencv-contrib-python), and that this is not possible in JupyterLite. Because it is anAttributeError, existinghasattr()checks still work, and a module that is present is left alone. The module list is OpenCV's, not MVTB's, so call sites don't change. A normalpip installof MVTB already brings in contrib, so this only appears in JupyterLite or after--no-deps. Tests included.🤖 Generated with Claude Code