Repository navigation
fix: Camera recognises JupyterLite using spatialmath's isnotebook - #185
Merged
Merged
Conversation
Camera used its own _isnotebook(), which only knew the Jupyter ZMQ shell and Colab, so in JupyterLite it took the desktop branch of its image plane reuse. spatialmath-python 1.1.19 has isnotebook(), which knows JupyterLite too, so use it and drop the copy. Fixes #166 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cameraused its own_isnotebook(), which only knew the Jupyter ZMQ shell and Colab, so in JupyterLite it took the desktop branch of its image plane reuse. spatialmath-python 1.1.19 hasisnotebook(), which also knows JupyterLite, so use it and drop the copy. The old test is replaced by one that checks the JupyterLite case.Fixes #166
🤖 Generated with Claude Code