Skip to content

fix: Camera recognises JupyterLite using spatialmath's isnotebook - #185

Merged
petercorke merged 2 commits into
mainfrom
fix/isnotebook-jupyterlite
Nov 20, 2026
Merged

petercorke merged 2 commits into
mainfrom
fix/isnotebook-jupyterlite

Conversation

@petercorke

Copy link
Copy Markdown
Owner

Camera used its own _isnotebook(), which only knew the Jupyter ZMQ shell and Colab, so in JupyterLite it took the desktop branch of its image plane reuse. spatialmath-python 1.1.19 has isnotebook(), which also knows JupyterLite, so use it and drop the copy. The old test is replaced by one that checks the JupyterLite case.

Fixes #166

🤖 Generated with Claude Code

Camera used its own _isnotebook(), which only knew the Jupyter ZMQ shell and Colab, so in
JupyterLite it took the desktop branch of its image plane reuse.  spatialmath-python
1.1.19 has isnotebook(), which knows JupyterLite too, so use it and drop the copy.

Fixes #166

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -4 complexity · 0 duplication

Metric Results
Complexity -4
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@petercorke
petercorke merged commit bbe8342 into main Nov 20, 2026
31 checks passed
@petercorke
petercorke deleted the fix/isnotebook-jupyterlite branch November 20, 2026 02:35
@github-actions github-actions Bot mentioned this pull request Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_isnotebook() does not recognise JupyterLite

1 participant