Repository navigation
ci: run mypy and check the wheel carries py.typed - #186
Merged
Merged
Conversation
A typecheck job, as in bdsim, part of the required All tests passed check. The package passes mypy with no errors, so any new error fails the build. CONTRIBUTING.md said pyright, which nothing runs and which has no configuration; AGENTS.md said mypy was not in CI. Fixes #40 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
The first run of the typecheck job failed on 14 errors that I did not see locally: the job had no open3d or rosbags, so the type: ignore comments for them were unused, and newer OpenCV stubs changed what kmeans reports. Install them in the job, and call cv2.kmeans through Any, since its stubs differ between OpenCV releases. Checked in a clean virtual environment with the job's packages: mypy reports no errors. Refs #40 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
typecheckjob, as in bdsim, to CI and to the requiredAll tests passedcheck. It runsmypy(the package passes with no errors since #176) and checks the built wheel containspy.typed. CONTRIBUTING.md said pyright, which nothing runs; AGENTS.md said mypy was not in CI. Both are corrected.Fixes #40
🤖 Generated with Claude Code