Skip to content

ci: run mypy and check the wheel carries py.typed - #186

Merged
petercorke merged 2 commits into
mainfrom
ci/mypy
Nov 20, 2026
Merged

petercorke merged 2 commits into
mainfrom
ci/mypy

Conversation

@petercorke

Copy link
Copy Markdown
Owner

Adds a typecheck job, as in bdsim, to CI and to the required All tests passed check. It runs mypy (the package passes with no errors since #176) and checks the built wheel contains py.typed. CONTRIBUTING.md said pyright, which nothing runs; AGENTS.md said mypy was not in CI. Both are corrected.

Fixes #40

🤖 Generated with Claude Code

A typecheck job, as in bdsim, part of the required All tests passed check.  The package
passes mypy with no errors, so any new error fails the build.  CONTRIBUTING.md said
pyright, which nothing runs and which has no configuration; AGENTS.md said mypy was not
in CI.

Fixes #40

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codacy-production

codacy-production Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

The first run of the typecheck job failed on 14 errors that I did not see locally: the job
had no open3d or rosbags, so the type: ignore comments for them were unused, and newer
OpenCV stubs changed what kmeans reports.  Install them in the job, and call cv2.kmeans
through Any, since its stubs differ between OpenCV releases.  Checked in a clean virtual
environment with the job's packages: mypy reports no errors.

Refs #40

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@petercorke
petercorke merged commit 4d6415d into main Nov 20, 2026
34 checks passed
@petercorke
petercorke deleted the ci/mypy branch November 20, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt mypy (as in RTB): 534 errors to ratchet down, not yet run in CI

1 participant