Repository navigation
feat: depth_units turns 0 into NaN in an integer depth image - #188
Merged
Merged
Conversation
In an integer depth image 0 means no measurement, and in a float one (REP 118) NaN does. A converted integer image now has NaN where it was 0, so that no measurement means the same in both and a minimum, mean or point cloud does not take it for a depth of 0 m. A 32FC1 image already uses NaN and is left alone. Checked on the real bags. Refs #151 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an integer depth image 0 means no measurement, and in a float one (REP 118) NaN does. A converted integer image now has NaN where it was 0, so that no measurement means the same in both and a minimum, mean or point cloud does not take it for a depth of 0 m. A
32FC1image already uses NaN and is left alone. There is no extra argument.This changes the output that #187 (ROSBag depth_units returns depth images as float32 metres, merged) added, which has not been released. Docstring and tests updated, and checked on the real bags in
bags/.Fixes #151
🤖 Generated with Claude Code