Skip to content

feat: use spatialmath's set_window_title and remove MVTB's own - #190

Merged
petercorke merged 2 commits into
mainfrom
refactor/set-window-title
Nov 20, 2026
Merged

petercorke merged 2 commits into
mainfrom
refactor/set-window-title

Conversation

@petercorke

Copy link
Copy Markdown
Owner

spatialmath-python 1.1.19, already MVTB's minimum, has set_window_title(fig, title), which does nothing for a figure with no window. MVTB had its own set_window_title(title) on the current figure, exported publicly, and six places that set the title directly with a try/except or a manager check. All use the spatialmath function now, and the local helper and its exports are removed. Code that imported set_window_title from MVTB should import it from spatialmath.base, which takes the figure as its first argument. Tests added, and the example that used the old helper is updated.

Fixes #147

🤖 Generated with Claude Code

spatialmath-python 1.1.19, already the minimum, has set_window_title(fig, title), which
does nothing for a figure with no window.  MVTB had its own set_window_title(title) on the
current figure, exported publicly, and six places that set the title directly with a
try/except or a manager check.  All use the spatialmath function now, and the local helper
and its exports are gone.  Code that imported set_window_title from MVTB should import it
from spatialmath.base, which takes the figure as its first argument.

Fixes #147

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -1 complexity · 0 duplication

Metric Results
Complexity -1
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@petercorke
petercorke merged commit df755a4 into main Nov 20, 2026
32 checks passed
@petercorke
petercorke deleted the refactor/set-window-title branch November 20, 2026 05:20
@github-actions github-actions Bot mentioned this pull request Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use spatialmath.base.set_window_title once released (SMTB #263), remove the local copies

1 participant