Repository navigation
feat: use spatialmath's set_window_title and remove MVTB's own - #190
Merged
Merged
Conversation
spatialmath-python 1.1.19, already the minimum, has set_window_title(fig, title), which does nothing for a figure with no window. MVTB had its own set_window_title(title) on the current figure, exported publicly, and six places that set the title directly with a try/except or a manager check. All use the spatialmath function now, and the local helper and its exports are gone. Code that imported set_window_title from MVTB should import it from spatialmath.base, which takes the figure as its first argument. Fixes #147 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -1 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spatialmath-python 1.1.19, already MVTB's minimum, has
set_window_title(fig, title), which does nothing for a figure with no window. MVTB had its ownset_window_title(title)on the current figure, exported publicly, and six places that set the title directly with a try/except or a manager check. All use the spatialmath function now, and the local helper and its exports are removed. Code that importedset_window_titlefrom MVTB should import it fromspatialmath.base, which takes the figure as its first argument. Tests added, and the example that used the old helper is updated.Fixes #147
🤖 Generated with Claude Code