Repository navigation
fix: connect(edge=) sets and validates the supplied edge's endpoints - #30
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
v.connect(w, edge=Edge()) added an edge built without vertices to the graph but left edge.v1/edge.v2 as None, so incidence() and remove_edge() then hit their asserts. The endpoints are now set, and an edge that already names other vertices is rejected before anything is changed (either order is accepted for undirected edges). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…raph Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 21 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 85.05% 86.14% +1.09%
==========================================
Files 2 2
Lines 776 787 +11
==========================================
+ Hits 660 678 +18
+ Misses 116 109 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.connect(v2, edge=e)with a caller-supplied edge built without vertices added the edge to the graph but lefte.v1ande.v2asNone. The edge was then corrupt:incidence()andremove_edge()hit theirassert ... is not None.Edge.connect()set the endpoints, butBaseVertex.connect(edge=...)did not, and it also never checked an edge that already named other vertices.Change
v1/v2set to the vertices being connected.ValueErrorbefore anything is changed (no half-added edge).UGraphedge may be given in either order, since it has no direction. ADGraphedge must run exactlyself -> dest.BaseVertex.connect,UVertex.connect,DVertex.connectandEdge.connectnow state the endpoint rule and:raises:.Edge.connectgains a warning that it is meant for an edge not yet in a graph.Notes
Edge(a, b)passed toa.connect(b, edge=...), andEdge.connect(v1, v2).vertex_class/edge_classPR builds on it, so it is worth merging first.Tests
tests/test_connect_edge.py, 14 tests acrossUGraphandDGraph; nine fail onmain.🤖 Generated with Claude Code