Repository navigation
fix(blocks): ARMPLOT moves the robot plot, which #873 left pinned to the initial pose - #939
Merged
Merged
Conversation
…the initial pose start() plots the robot with its initial pose, which since #873 pins the plot to that pose, so setting robot.q in step() no longer moved the arm. Set the pose of each plot as well, in _set_pose(), so that code that drives the block differently can call it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
6 tasks done
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to RTB!
Summary
ARMPLOTno longer moves the arm.ArmPlot.start()plots the robot with its initial pose,robot.plot(self.q0, ...), which since #873 pins the robot plot to that pose, so settingrobot.qinstep()no longer moves it. Every diagram that animates an arm shows the robot frozen at its starting pose.Found running bdsim's
computed-torquemodel in the ICRA 2026 tutorial notebook, where the scope updated and the robot did not. Confirmed by rendering every frame: the arm geometry was identical in all 304 frames before this change, and distinct in all 304 after.ArmPlot.step()now calls a newArmPlot._set_pose(q), which setsrobot.qand the pose of each robot plot in the scene._set_poseis the one place that knows how the plots hold a pose, so code that drives the block differently, such as bdsim's notebook support, can call it and not repeat the logic. bdsim's PR for that is fix: notebook ARMPLOT asks the block to move the robot plot bdsim#254.Public behaviour: the arm in
ARMPLOTmoves again. No change to numerical results.Test:
test_armplot_follows_its_inputrunsJTRAJintoARMPLOTand checks the plotted arm ends atqf. It fails without the change.This change was written with AI assistance (Claude Code); I have read the diff myself.
Related issue
Regression from #873.
Checklist
type: description)pytest)🤖 Generated with Claude Code