Skip to content

fix(deps): require spatialmath-python 1.1.19 and use what it now provides - #942

Open
petercorke wants to merge 4 commits into
mainfrom
chore/spatialmath-1.1.19
Open

petercorke wants to merge 4 commits into
mainfrom
chore/spatialmath-1.1.19

Conversation

@petercorke

@petercorke petercorke commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

Spatial Math (SMTB) 1.1.19 is out, so RTB can raise its minimum and drop two workarounds.

Behaviour

No change to numerical results or public behaviour. SMTB's set_window_title behaves the same as the copy removed. The only visible change is the new minimum version of SMTB.

Not in this PR

The notebook bootstrap deps=False workaround, and RTB's own isnotebook() versus SMTB's environment(). The same set_window_title change for MVTB and bdsim is tracked in their own Issues, since they are separate repositories.

What I ran

Against an isolated overlay of SMTB 1.1.19 (the dev environment has 1.1.18), with the pure-Python fallbacks: the full test suite on this branch and on plain main. Both give 19 failures and the failing tests are identical; they fail on main in this environment too. tests/test_pyplot_backend_fixes.py passes. Not run: the compiled extensions, and mypy locally (CI runs it).

AI assistance

Written with Claude Code (Claude Sonnet 5.5).

🤖 Generated with Claude Code

petercorke and others added 3 commits November 16, 2026 17:13
1.1.18 had pre-commit as a runtime dependency, which breaks the in-browser
install (Refs #742). 1.1.19 moved it to the dev extra, and adds
set_window_title and stacked (N,4,4) pose arrays, used in the next commits.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Spatial Math 1.1.19 provides it, so the fallback copy in tools/plot.py and
its tests go. The call sites in PyPlot, PyPlot2 and Vehicle import it from
spatialmath.base; the tests that patch it at those call sites are unchanged.

Fixes #789

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
SE3 accepts an (N,4,4) array since Spatial Math 1.1.19 (SMTB #236), so the
conversion to a list of matrices is no longer needed. The shape check and
its ValueError are unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codacy-production

codacy-production Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 4 complexity · 0 duplication

Metric Results
Complexity 4
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

_as_se3 backs every Robot.ik_* and Robot.ikine_* method, but only the ikine_*
methods were tested with an (N,4,4) array. A direct test covers all of them,
and fails on Spatial Math 1.1.18, which cannot build an SE3 from such an array.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tools.plot: drop the set_window_title copy once Spatial Math has it (SMTB #263)

1 participant