Repository navigation
Conversation
Enable TextInputLayout's password toggle end icon mode for password fields in prompt dialogs so users can inspect and verify entered passwords.
SessionActivity uses shortEdges cutout mode for immersive fullscreen display. Dialog overlays inherited this from the activity's theme, allowing WindowManager to center the dialog into the top cutout and status bar area when the soft keyboard opened. On any subsequent relayout request (such as toggling password visibility with transformation methods), WindowManager clamped the window's decor frame below the cutout without updating the underlying window input geometry, causing the visual dialog to jump down by the status bar height while touch hitboxes stayed at the previous coordinates. Setting windowLayoutInDisplayCutoutMode to never on the dialog overlay ensures dialogs are placed below the cutout immediately when the IME opens.
lainefox
force-pushed
the
password-view-toggle
branch
from
November 1, 2026 01:29
d4bd3a5 to
f69af34
Compare
pgaskin
self-requested a review
November 1, 2026 01:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pull request adds a button to reveal the password in the auth dialog. useful for typing in long or complex passwords.
changes:
testing:
changes partially assisted by a llm (opencode, model: big pickle)