Skip to content

feat: re-write uuid functions (calls + DEFAULT) in omni insert - #1556

Merged
jkaczman merged 2 commits into
mainfrom
jk-omni-writes-uuid-func
Sep 16, 2026
Merged

jkaczman merged 2 commits into
mainfrom
jk-omni-writes-uuid-func

Conversation

@jkaczman

@jkaczman jkaczman commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Adds support to rewrite UUID functions (uuidv4, uuidv7, gen_random_uuid) for omni inserts on top of the support for date-time functions (from #1541). Some refactoring to push those two classes of functions into separate files and generalize handling a bit more.

It does not support specifying an interval argument within uuidv7() yet.

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.56057% with 65 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...r/rewrite/statement/non_deterministic_funcs/mod.rs 85.03% 38 Missing ⚠️
.../rewrite/statement/non_deterministic_funcs/time.rs 86.86% 18 Missing ⚠️
.../rewrite/statement/non_deterministic_funcs/uuid.rs 65.38% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jkaczman
jkaczman marked this pull request as ready for review September 16, 2026 19:08

@levkk levkk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@jkaczman
jkaczman changed the base branch from main to jk-bump-postgres-in-ci September 16, 2026 20:09
@jkaczman
jkaczman added this pull request to stack #1566 September 16, 2026 20:09
@jkaczman
jkaczman force-pushed the jk-omni-writes-uuid-func branch 2 times, most recently from e5c7b00 to 35e6e1c Compare September 16, 2026 21:05
Base automatically changed from jk-bump-postgres-in-ci to main September 16, 2026 21:49
@jkaczman
jkaczman force-pushed the jk-omni-writes-uuid-func branch from 35e6e1c to 1d6511c Compare September 16, 2026 21:49
@jkaczman
jkaczman merged commit 7235dd7 into main Sep 16, 2026
28 of 29 checks passed
@jkaczman
jkaczman deleted the jk-omni-writes-uuid-func branch September 16, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants