Conversation
mehcode
force-pushed
the
rl-sigterm-plugin-shutdown
branch
from
September 18, 2026 01:48
c024ed0 to
6a6d08c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1537
Move
SIGTERMhandling to aselect!in main (inside theblock_on) and return from main instead of callingexit(0). Behavior should be the same with the addition of calling plugin shutdowns now.I edited the integration test and added a
finito make sure it runs on SIGTERM but it breaks the integration test inside of gdb (or at least causes it to think a failure happened), so not sure the best way to add a persistent test for this.Its technically possible to miss a plugin shutdown still if plugins register correctly but
build_runtimereturns an error. If you think its important to make this a guarantee we could return a RAII guard fromplugin::load_from_config.I kept the immediate nature of SIGTERM with
runtime.shutdown_background. Technically SIGTERM is supposed to not be immediate (and let all tasks close properly) so that should probably beruntime.shutdown_timeout(..), happy to tweak that if you agree but I left it for now.