Repository navigation
fix(update): keep re-checking a KEPT (frozen) capability on every run (PHARN-13) - #207
Merged
Merged
Conversation
… (PHARN-13) After an update kept an unparseable capability and bumped skillsVersion, the next run at the same version returned "Already up to date" before fetching, so the KEPT report never repeated and the capability's bytes stayed stale even after a pharn upgrade that could parse it. `update` now records the KEPT `role:name` keys in an additive `frozenCapabilities` config field (sorted, omitted when empty) and skips the same-version early return while it is non-empty. Ingest drops a malformed value whole, which restores the previous behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TvcuVhk8hTeDskp5pAJhnc
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
updatekept an unparseable ("frozen") capability, it still bumpedskillsVersion. The next run at the same version then hit "Already up to date" without fetching, which broke the docs' promise indocs/commands/update.md:Fix
frozenCapabilitiesfield in the config (existing configs still load). It holds the sortedrole:nameof each installed capability that update kept unparsed, and is left out when there are none.updateskips the same-version early return, so every run fetches and re-checks.addstays unblocked.Tests
11 new tests fail on the old code and pass now:
One more test checks that the early return still fires when no capability is frozen. The pipeline artifacts are in
.dev/features/frozen-capability-recheck/.Local gates, run as a non-root user on node 22: all green. 1384/1384 tests pass and statement coverage is 97.18%.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TvcuVhk8hTeDskp5pAJhnc
Generated by Claude Code