fix(capability-index): strict frontmatter fence + refuse duplicate keys (PHARN-14) - #208
Merged
Merged
Conversation
…fuse duplicate keys (PHARN-14) The lazy fence regex skipped an empty block (`---\n---`) and read role/applies from the document body. And the first-match field reader could disagree with pharn-oss's validator (last match) when a key was duplicated. Both shapes now land in `unknown` — named, never installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TvcuVhk8hTeDskp5pAJhnc
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
extractFrontmatterused the lazy regex/^---\n([\s\S]*?)\n---/. With an empty block (---\n---), it readrole/appliesfrom the document body.readFieldtook the first occurrence of a duplicated key, while pharn-oss's validator takes the last. A capability could therefore install with anappliesthat the upstream gate never checked.Fix
---, and the block ends at the next---line (trailing whitespace is allowed).roleorapplieskey that appears more than once raisesManifestValidationError. The capability then lands inunknown: it is named in a warning and never installed. An already-installed one is KEPT and re-checked (PHARN-13).Tests
applies, duplicaterole. Three of them fail on the old code; the unterminated-fence case already failed there too.roles:, indentedapplies:) stay ignored..dev/features/strict-frontmatter-fence/.🤖 Generated with Claude Code
https://claude.ai/code/session_01TvcuVhk8hTeDskp5pAJhnc
Generated by Claude Code