docs: catch README and getting-started up with pharn-oss 6.20.2 - #214
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pharn-oss 6.9.0 -> 6.20.2 added an eighth pipeline stage, /pharn-test, between grill and build (6.17.0-6.20.0), plus a /pharn-loop Stop hook (6.12.0) and project SPEC templates (6.14.0). Both docs still described seven stages. - Pipeline: add `test`; stage table gains /pharn-test; /pharn-ship runs stages 1-7; /pharn-plan and /pharn-verify rows name the AC tests. - Quick start / getting-started: the test stage needs a `test` script with per-test JSON results (`testResults` in pharn.config.json), else /pharn-loop ends `blocked: no-test-runner` -- the README's own create-next-app example hits this. - Per-feature artifacts: AC-TESTS.md, AC-TESTS.lock.json, BRIEFING.md / LOOP.md, RUN-REPORT.md, cost.json, *-report.json. - After install: the require-loop-record.cjs Stop hook, and that a preserved or pre-6.12.0 settings.json needs its entry copied by hand. - Correct a pre-existing error: /pharn-loop does not keep the spec approval gate -- the model approves its own spec; the human decides after the run. - getting-started: ten -> eleven installed commands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XN3wDK2oR4TgcnPGZ6Fs9R
PrzemekGalarowicz
force-pushed
the
claude/determined-fermi-5lcaqp
branch
from
September 24, 2026 19:04
043cd26 to
ccfdedb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
pharn-oss moved from 6.9.0 to 6.20.2 over its last 30 commits. The biggest change is a new eighth pipeline stage,
/pharn-test, which runs between grill and build (6.17.0–6.20.0). Our docs still described seven stages. This PR updatesREADME.mdanddocs/getting-started.mdto match:test, so there are eight stages. The stage table gets a/pharn-testrow, and/pharn-shipnow runs stages 1-7. The/pharn-planand/pharn-verifyrows now mention the acceptance-criterion (AC) tests.testscript whose reporter writes per-test JSON, configured throughtestResultsinpharn.config.json. Without it,/pharn-loopends withblocked: no-test-runner. The README's owncreate-next-appexample runs into exactly this.AC-TESTS.md,AC-TESTS.lock.json,BRIEFING.md/LOOP.md,RUN-REPORT.md,cost.jsonand the*-report.jsonfiles.require-loop-record.cjsStophook (6.12.0). Asettings.jsonthat was preserved, or created before 6.12.0, needs its entry copied in by hand./pharn-specuses the project's ownpharn.spec-template.mdif present (6.14.0), and that the write guard blocks Claude Code's edit tools on that file./pharn-loopkeeps both human gates. It doesn't: the model approves its own spec, and the human decides after the run.docs/getting-started.md: "ten" installed commands becomes "eleven".Type of change
feat— new stack option, wizard step, or command capabilityfix— bug fixdocs— docs-only changechore/refactor— tooling or internal restructure, no behavior changeArea(s) touched
docs
Checklist
.js-extension import convention.tests/*.test.tswhen wizard behavior changed (n/a: no behavior change).docs/page; everything described is shipped upstream in pharn-oss 6.20.2.src/lib/validate.ts(n/a: no remote-input handling touched).Quality gates
npm run check: run in a clean clone afternpm ci.format:check,lint,lint:mdandtypecheckpass.testhas 5 failures intests/init.test.ts/tests/update.test.tsthat fail the same way on the unpatched base: the environment runs as root, so their permission-based failure injection never triggers.tests/docs-install-tables.test.tspasses.npm run build: not run (docs-only change).npm run test:coverage: not run; CI covers it.Notes for the reviewer
pharn initrebuildspharn.config.jsonfrom scratch (src/steps/install-archetype.ts). That drops a user-addedtestResultsblock, which the new test stage depends on.add,updateandremovekeep it.🤖 Generated with Claude Code
https://claude.ai/code/session_01XN3wDK2oR4TgcnPGZ6Fs9R
Generated by Claude Code