fix(ship): quick base in Node + briefing path (6.28.6) — LOW L1/L8 - #289
Draft
PrzemekGalarowicz wants to merge 1 commit into
Draft
PrzemekGalarowicz wants to merge 1 commit into
PrzemekGalarowicz wants to merge 1 commit into
Conversation
….28.6) LOW L1: check-quick-scope --base auto [--from-ref] via regress-base-core.mjs LOW L8: pharn-ship Step 2c uses .pharn/pharn-ship/<name>/briefing-draft.md Co-authored-by: pgalarowicz <pgalarowicz@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second LOW backlog delivery (L1, L8). PR only — not merged (per request).
L1 — Quick mode base resolution
pharn/floor/regress-base-core.mjsimplementsBASE_RULEgit work viagitSync(same logic as/pharn-regressbase phase).check-quick-scope.mjsaccepts--base autoand optional--from-ref '<ref>'so/pharn-ship --quickitem 7 no longer tells the orchestrator to run shellgit rev-parseon untrusted refs./pharn-loop --quickkeeps--base '<base sha>'from the regress stage.L8 — Briefing draft path
.pharn/pharn-ship/<name>/briefing-draft.mdinstead of/tmp/briefing-draft.md.SKILLS_VERSION: 6.28.6
Note on CI / tests
regress-base-core.test.mjsadded;validate.mjsGREEN.check-quick-scope.test.mjs★ HOSTILE cases already fail onmainin this environment (reproduced before these edits); not introduced by this diff.Related
Remaining LOW
L2–L4, L10–L22 still open for follow-up PRs.