Skip to content

fix(ship): quick base in Node + briefing path (6.28.6) — LOW L1/L8 - #289

Draft
PrzemekGalarowicz wants to merge 1 commit into
mainfrom
cursor/low-findings-batch-2-fd35
Draft

PrzemekGalarowicz wants to merge 1 commit into
mainfrom
cursor/low-findings-batch-2-fd35

Conversation

@PrzemekGalarowicz

Copy link
Copy Markdown
Contributor

Summary

Second LOW backlog delivery (L1, L8). PR only — not merged (per request).

L1 — Quick mode base resolution

  • New pharn/floor/regress-base-core.mjs implements BASE_RULE git work via gitSync (same logic as /pharn-regress base phase).
  • check-quick-scope.mjs accepts --base auto and optional --from-ref '<ref>' so /pharn-ship --quick item 7 no longer tells the orchestrator to run shell git rev-parse on untrusted refs.
  • /pharn-loop --quick keeps --base '<base sha>' from the regress stage.

L8 — Briefing draft path

  • Step 2c renders to .pharn/pharn-ship/<name>/briefing-draft.md instead of /tmp/briefing-draft.md.

SKILLS_VERSION: 6.28.6

Note on CI / tests

  • regress-base-core.test.mjs added; validate.mjs GREEN.
  • Some check-quick-scope.test.mjs ★ HOSTILE cases already fail on main in this environment (reproduced before these edits); not introduced by this diff.

Related

Remaining LOW

L2–L4, L10–L22 still open for follow-up PRs.

Open in Web Open in Cursor 

….28.6)

LOW L1: check-quick-scope --base auto [--from-ref] via regress-base-core.mjs
LOW L8: pharn-ship Step 2c uses .pharn/pharn-ship/<name>/briefing-draft.md

Co-authored-by: pgalarowicz <pgalarowicz@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants