fix(floor): the AC gate — a PLAN cannot scope the test infrastructure it is judged by; unrelated test anomalies no longer void the record (6.31.0)

[PrzemekGalarowicz]

Summary

Two holes in the AC gate, both from the review's findings H2 and M6. Released as SKILLS_VERSION 6.31.0 (minor), planned as
6.29.0 and renumbered twice: #290 released 6.29.0 and #292 released 6.30.0 first.

H2 — a PLAN could scope the test infrastructure it is judged by

A build scoped to AC-TESTS.lock.json re-pinned its own change with every check green. A PLAN-scoped build also wrote the
pharn-json reporter a level gate's script names, and the pin did not cover it.

• check-ac-tests.mjs gains the kind ac-artifact-in-plan: this feature's AC-TESTS.md or lock in PLAN.md ## Files is RED.

• test-infra-in-plan widens to cover root package-manager configs (.npmrc/.yarnrc/.yarnrc.yml) and every file a level
  gate's script names.

• The test-infra pin moves to lock schema ac-tests-lock/4; /3, /2 and /1 are still read. It now covers:

  • the scripts a pinned value chains to (transitively, own-property only, refused past 8 hops);
  • the regular files a pinned value names;
  • package.json's jest key, as a canonical digest;
  • the root package-manager configs, hash only.

  All of it comes from one closed literal token pass (test-infra-core.mjs), never a shell parse.

• A /3 lock is judged by what it pinned. Whatever only /4 pins reads unpinned: --check is RED and the AC gate reports
  test-infra-unpinned. A pre-6.31.0 floor reads a /4 lock as lock-unusable / ac-tests-modified, never GREEN.

M6 — one anomaly anywhere voided the whole AC record

• A flaky test or expected failure the report marks, or a duplicate test id, is now a per-test anomaly in the record
  (anomalies[]). It is no longer a record refusal.
• It makes an AC UNMEASURED only when it sits in a file mapped to that AC at one of its level gates. Every other anomaly is
  reported in unmapped_anomalies, in the red run, the ac_gate block, VERIFY.md and RUN-REPORT.md. No verdict reads it.

Bounds, stated where the contract lists them

• The in-process bound comes first: code the build writes runs inside the test process and can switch assertions or the
  reporter off there. A green pin never means the build could not forge the AC gate.
• The rest of the NOT-caught list is in test-infra-core.mjs's header and is restated in ac-tests.md.
• verify-rechecks-test-stage (F4) is a named follow-up, stated as a bound.

Human-only edit (optional, not blocking)

.dev/features/ac-gate-plan-scope/proposed/ stages a LIMITS.md §9 patch. The agent cannot write that file. It is optional,
can be applied after this merges on its own branch (APPLY.md), and no gate waits on it.

Verdicts (floor)

• validate: GREEN (36 capabilities).
• /pharn-dev-regress (base c1bf663, after merging main): no-regressions.
• /pharn-dev-verify (after merging main): FAIL on reconcile alone; the other six gates exit 0 (4170/4170 tests).
  • The 50 escapes are exactly the files origin/main changed (70cb51c..c1bf663: fix(floor): the stage scripts' git calls no longer die past 1 MiB of output (6.28.3) #286, docs: audit gaps — Node floor version, command budget, SECURITY 6.24.0 #287, fix(floor): a cost ledger counts only its own run's requests (6.29.0) #290) after this build
    anchored its reconcile epoch. Escapes minus that list is the empty set (VERIFY.md).
  • The baseline was not re-anchored.
  • The pre-merge verify read PASS, reconcile CLEAN.
• check:changelog-entry: GREEN against origin/main at 109a4af; this PR opens ## [6.31.0] - 2026-09-27.
• Review: GREEN at the floor, with 12 advisory findings. F1–F3 and every minor were fixed at GATE 2 (BUILD.md, "GATE 2 —
  the FIX round").
• Lesson L65 promoted. Both gates and the promotion's accept were decisions the maintainer delegated to the orchestrating
  model, not human approvals.

Run records: .dev/features/ac-gate-plan-scope/ (PLAN, GRILL, BUILD, REGRESSION, VERIFY, REVIEW, SHIP).

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 7aa39015-bfee-4106-808f-0b17b300b5b8

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}