perf(commands): load /pharn-loop and /pharn-ship quick and stop text only when needed (6.32.0) - #294
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…/pharn-ship (6.32.0) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t pins) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tion and not-loaded rule; narrow placement claims REVIEW.md FG1: POINTER_PINS gains a per-part tier (WHEN and the not-loaded rule), every pin a control, the review's six mutants kept as regressions, and R5b (a part's file name only in its pointer). FG2: CLAUDE.md, CONTRIBUTING.md, the test header and both claims bullets narrowed to what R6/R7 pin. Advisory: close pointers gain the untrusted-path sentence, every pointer a compaction re-read; loop stop routing matches Steps 1a/2; quantifiers and numbers corrected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-context # Conflicts: # CHANGELOG.md # README.md # SKILLS_VERSION
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/pharn-loopand/pharn-shipno longer send their--quickdeltas on every request of a full run, or their stop procedure on every request before the stop. Each command keeps its entry-to-stop steps and gains two part files in.claude/commands/, each read at one named point:pharn-<cmd>-quick.md— read only for a--quickrun, at entry, batched with a call the run already makes;pharn-<cmd>-close.md— the stop steps, the claims block and the Final step. The loop reads it at its first stop; ship reads it with step 7's return marker, or at an earlier STOP.Each part has one pointer in its command. The pointer names the exact path, when the part is read, that it is trusted command text, and that it is re-read after a compaction. It also carries a not-loaded rule: stop, and never run a part from memory. No stage, order, route, check, stop decision, retry bound, ledger rule, commit rule or human gate moved. SKILLS_VERSION 6.31.2 → 6.32.0.
MIN_CLIis unchanged: pharn-cli 0.7.0's own manifest and install code copy all four parts byte-identical.Is it an optimization? (bytes measured; requests/tokens estimated)
--quick, 1 iter--quick, GATE 2Bytes are measured. Request counts and tokens are estimates from a request profile counted over the pinned steps. No live before/after run was made. An unbatched quick Read would cost about 130k tokens at the larger prefix, more than a one-iteration quick loop saves; that is why the quick reads are batched.
Tests
.dev/floor/command-family.test.mjspins:Every pin has a negative control, and the review's six mutants are kept as regressions. The existing command pins read a command together with its parts through the dev-only helper
.dev/floor/command-family.mjs. Not pinned: which file a body line under an unchanged heading sits in. Advisory: that a run reads a part at its point, and that a model follows a part it received as a Read result the way it follows an invoked command body. That was not run live; the follow-ups areparts-live-runandparts-visibility-probe.Review
An independent
/pharn-dev-reviewfound 2 floor-gate findings. Both were claims that promised more than the tests pinned, and both are fixed ind2a059d. The advisory findings are applied, or stated inBUILD.md, "After the review". Pipeline records:.dev/features/orchestrator-context/(PLAN, GRILL, BUILD, REGRESSION, VERIFY, REVIEW, SHIP).Local verification on the merged tree
npm run check: every gate is green up tocheck:reconcile.check:reconcileis red only on the 5 files main's 6.31.2 changed; the build's epoch can't attribute the merge's writes, and CI readsNO_BASELINE.npm test: 4266 / 4267 pass. The one failure is 6.31.2's own macOS-onlyprojectRoot()test, which fails the same way onorigin/main.validate: a clean export is GREEN, 36 capabilities.check:changelog-entry: GREEN.🤖 Generated with Claude Code