Repository navigation
fix(tests): fix remaining 7 GuardPattern test failures and revert CI diagnostics - #12
Merged
Merged
Conversation
- Separate null input tests from invalid format tests since pattern methods throw ArgumentNullException for null inputs (via ArgumentNullException.ThrowIfNull) not ArgumentException - Update phone number regex to support international formats like +1-555-123-4567 and +44 20 7123 4567 - Use Assert.Contains instead of Assert.Equal for custom message test since ArgumentException appends parameter name to message - Revert CI workflow to standard (remove diagnostic logging)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArgumentNullExceptionfor null inputs (viaArgumentNullException.ThrowIfNull) notArgumentException+1-555-123-4567and+44 20 7123 4567Assert.Containsinstead ofAssert.Equalfor custom message test sinceArgumentExceptionappends the parameter name to the message|| trueand diagnostic log output from PR fix(demo): resolve compilation errors in InnovativeGuardDemo #11)Test plan