Skip to content

fix: terminal status edge cases (keyed suite list, --silent) - #416

Merged
roxblnfk merged 2 commits into
1.xfrom
fix/terminal-status-edge-cases
Nov 17, 2026
Merged

roxblnfk merged 2 commits into
1.xfrom
fix/terminal-status-edge-cases

Conversation

@roxblnfk

Copy link
Copy Markdown
Member

🔍 What was changed

  • The suite list from SuiteLocator is always a list. An interceptor filtering with array_filter() used to leave keys that made the terminal status divide by zero and stop the progress bar.
  • --silent (Symfony 7.2+) now maps to quiet verbosity, so run and init write no terminal status under it. Before, it mapped to normal verbosity in run.

Checklist

  • How was this tested:
    • Unit tests added
    • composer test:ci -- --type=!bench run locally (only the known Xdebug nesting errors in bench self-tests)

Documentation

  • Skill testo-run-tests lists --silent among the switches that turn the status off.

A `SuiteLocatorInterceptor` that filters with `array_filter()` returns a keyed array, and the terminal status counted positions in it, dividing by zero on such a list.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
…us off

Symfony 7.2 put `--silent` below `--quiet`, and the bridge mapped it to normal verbosity. It is compared by value because older Symfony versions lack the constant.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
@roxblnfk
roxblnfk requested a review from a team as a code owner November 17, 2026 15:45
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bridge/symfony-console/src/Command/Base.php 0.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@roxblnfk
roxblnfk merged commit d1ec71d into 1.x Nov 17, 2026
30 of 31 checks passed
@roxblnfk
roxblnfk deleted the fix/terminal-status-edge-cases branch November 17, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant