Repository navigation
fix: terminal status edge cases (keyed suite list, --silent) - #416
Merged
Merged
Conversation
A `SuiteLocatorInterceptor` that filters with `array_filter()` returns a keyed array, and the terminal status counted positions in it, dividing by zero on such a list. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
…us off Symfony 7.2 put `--silent` below `--quiet`, and the bridge mapped it to normal verbosity. It is compared by value because older Symfony versions lack the constant. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
SuiteLocatoris always a list. An interceptor filtering witharray_filter()used to leave keys that made the terminal status divide by zero and stop the progress bar.--silent(Symfony 7.2+) now maps to quiet verbosity, sorunandinitwrite no terminal status under it. Before, it mapped to normal verbosity inrun.Checklist
composer test:ci -- --type=!benchrun locally (only the known Xdebug nesting errors in bench self-tests)Documentation
testo-run-testslists--silentamong the switches that turn the status off.