Skip to content

fix: run on 32-bit PHP - #423

Merged
roxblnfk merged 4 commits into
1.xfrom
fix/32bit-int-overflow
Nov 18, 2026
Merged

roxblnfk merged 4 commits into
1.xfrom
fix/32bit-int-overflow

Conversation

@roxblnfk

@roxblnfk roxblnfk commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

🔍 What was changed

  • InterceptorOptions order constants fit into 32-bit int, relative order unchanged.
  • Terminal progress (OSC 7501) computes segment shares in float, so it no longer overflows on 32-bit PHP.
  • New CI job runs the suite on 32-bit PHP 8.4 (php:8.4-cli, linux/386). Rector fixtures are excluded there: Rector itself fails on 32-bit PHP (64-bit format codes are not available).

Checklist

On 32-bit PHP the four constants above PHP_INT_MAX compiled to float and every interceptor failed the `int $order` parameter. The relative order of all constants is unchanged.

Closes #418

Assisted-By: Claude Opus 5.5
On 32-bit PHP the integer products overflowed to float and `intdiv()` threw from the listener on every case start after about 2% of the run, freezing the progress bar.

Assisted-By: Claude Opus 5.5
@roxblnfk
roxblnfk requested a review from a team as a code owner November 18, 2026 06:20
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

test(bench): keep the gibibyte dataset within 32-bit int

Rector fixtures are excluded on 32-bit: Rector itself packs 64-bit values and fails there.

Assisted-By: Claude Opus 5.5
@roxblnfk
roxblnfk force-pushed the fix/32bit-int-overflow branch from 6cdeff4 to d2518e3 Compare November 18, 2026 06:27
@roxblnfk
roxblnfk merged commit f706e0d into 1.x Nov 18, 2026
17 checks passed
@roxblnfk
roxblnfk deleted the fix/32bit-int-overflow branch November 18, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testo fails on 32-bit PHP: InterceptorOptions orders do not fit in int

1 participant