Repository navigation
fix: run on 32-bit PHP - #423
Merged
Merged
Conversation
On 32-bit PHP the four constants above PHP_INT_MAX compiled to float and every interceptor failed the `int $order` parameter. The relative order of all constants is unchanged. Closes #418 Assisted-By: Claude Opus 5.5
On 32-bit PHP the integer products overflowed to float and `intdiv()` threw from the listener on every case start after about 2% of the run, freezing the progress bar. Assisted-By: Claude Opus 5.5
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
test(bench): keep the gibibyte dataset within 32-bit int Rector fixtures are excluded on 32-bit: Rector itself packs 64-bit values and fails there. Assisted-By: Claude Opus 5.5
roxblnfk
force-pushed
the
fix/32bit-int-overflow
branch
from
November 18, 2026 06:27
6cdeff4 to
d2518e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
InterceptorOptionsorder constants fit into 32-bit int, relative order unchanged.php:8.4-cli,linux/386). Rector fixtures are excluded there: Rector itself fails on 32-bit PHP (64-bit format codes are not available).Checklist