Skip to content

ci(release): retry release-please and the subtree split on failure - #425

Merged
roxblnfk merged 1 commit into
1.xfrom
ci/release-retry
Nov 18, 2026
Merged

roxblnfk merged 1 commit into
1.xfrom
ci/release-retry

Conversation

@roxblnfk

@roxblnfk roxblnfk commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

🔍 What was changed

  • release-please gets a second attempt 60 s after a failure. A collect step hands the outputs of the successful attempt to the rest of the job, and the root Packagist check still runs when the failed attempt already released the root.
  • The split runs from split-publish.sh instead of symplify/monorepo-split-github-action: it fails on a rejected push, pushes branch and tag with --atomic, retries up to 3 times, treats an existing tag as already published and refuses a tag older than the newest one in the split repo, so a re-run never rolls the branch back.

Why?

  • Onboarding error-handler hit both: a GitHub 5xx failed release-please, and the error-handler-0.1.1 tag was rejected by the split repo.
  • symplify ignores the exit codes of git push, so the rejected tag left the job green and no retry could fire.

Review notes

  • publish runs as (set -e; publish) outside an if: called as a condition, a function runs with set -e off and would push a half-copied tree.

Checklist

  • Tested
    • split-publish.sh against a local bare repo: empty target, rerun of a published tag, tag without changes, tag with added and removed files, remote rejecting tags (atomic push leaves branch and tags untouched, 3 attempts, exit 1), older tag refused without retry, empty branch argument, unreachable remote retried
    • Workflow run on GitHub

@roxblnfk
roxblnfk requested a review from a team as a code owner November 18, 2026 07:32
@roxblnfk roxblnfk changed the title ci(release): retry release-please and the subtree split once on failure ci(release): retry release-please and the subtree split on failure Nov 18, 2026
@roxblnfk
roxblnfk force-pushed the ci/release-retry branch 2 times, most recently from dbdaf7d to 2ad397b Compare November 18, 2026 08:16
The first release run after onboarding error-handler died on a GitHub 5xx while release-please walked the history of a package with no release yet, and the split of `error-handler-0.1.1` pushed the branch but had its tag rejected while the job stayed green: symplify/monorepo-split-github-action ignores the exit codes of its pushes. The split now runs from a script that fails on a rejected push, pushes branch and tag atomically and retries, so a retry can neither leave a tag on an orphan commit nor republish an older release over a newer one.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
@roxblnfk
roxblnfk merged commit bbc68ed into 1.x Nov 18, 2026
1 check passed
@roxblnfk
roxblnfk deleted the ci/release-retry branch November 18, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant