Repository navigation
ci(release): retry release-please and the subtree split on failure - #425
Merged
Merged
Conversation
roxblnfk
force-pushed
the
ci/release-retry
branch
from
November 18, 2026 08:09
0e78f6f to
6224afe
Compare
roxblnfk
force-pushed
the
ci/release-retry
branch
2 times, most recently
from
November 18, 2026 08:16
dbdaf7d to
2ad397b
Compare
The first release run after onboarding error-handler died on a GitHub 5xx while release-please walked the history of a package with no release yet, and the split of `error-handler-0.1.1` pushed the branch but had its tag rejected while the job stayed green: symplify/monorepo-split-github-action ignores the exit codes of its pushes. The split now runs from a script that fails on a rejected push, pushes branch and tag atomically and retries, so a retry can neither leave a tag on an orphan commit nor republish an older release over a newer one. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
roxblnfk
force-pushed
the
ci/release-retry
branch
from
November 18, 2026 08:20
2ad397b to
6c2db30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
split-publish.shinstead ofsymplify/monorepo-split-github-action: it fails on a rejected push, pushes branch and tag with--atomic, retries up to 3 times, treats an existing tag as already published and refuses a tag older than the newest one in the split repo, so a re-run never rolls the branch back.Why?
error-handlerhit both: a GitHub 5xx failed release-please, and theerror-handler-0.1.1tag was rejected by the split repo.git push, so the rejected tag left the job green and no retry could fire.Review notes
publishruns as(set -e; publish)outside anif: called as a condition, a function runs withset -eoff and would push a half-copied tree.Checklist
split-publish.shagainst a local bare repo: empty target, rerun of a published tag, tag without changes, tag with added and removed files, remote rejecting tags (atomic push leaves branch and tags untouched, 3 attempts, exit 1), older tag refused without retry, empty branch argument, unreachable remote retried