Repository navigation
Conversation
… dropping them fix(rector): rewrite `parent::` calls in an anonymous class detached from `TestCase` Only `TestCase` hook calls carry nothing once the class is detached; dropping the rest silently changed what a test checks. The other `parent::` calls into PHPUnit now take the `self::`/`$this->` spelling the skip and expectation rules already convert, and an anonymous class reads its ancestry from the base it names. Fixes #410 Fixes #411 Assisted-By: Claude Opus 5.5
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
ExtendsTestCaseToTestoRectordrops onlyparent::calls toTestCasehooks (setUp(),tearDown(),assertPostConditions()and the like). Otherparent::calls into PHPUnit becomeself::(static) or$this->, soparent::markTestSkipped()turns into#[Skip]andparent::expectException()intoExpect::exception()under the full set.parent::addToAssertionCount(), now stays visible as$this->addToAssertionCount()instead of disappearing.parent::X()inside the class's own override ofXis dropped, since$this->X()there would recurse.TestCasenow gets itsparent::calls handled too; its ancestry is read from the base it names.Checklist
parent::calls to TestCase skip and expectation methods are silently dropped #410parent::setUp()is kept in an anonymous class detached from TestCase #411phpunit-to-testoset fixtures addedBridge/RectorandBridge/Rector/Unitsuites pass locallyDocumentation
FEATURE_PARITY.md,PhpunitToTesto/TODO.mdand thetesto-migrate-from-phpunitskill describe the new behaviour.