Skip to content

fix(error-handler): log unhandled errors and stack verdicts through the messenger - #436

Merged
roxblnfk merged 1 commit into
1.xfrom
fix/error-handler-messenger
Nov 19, 2026
Merged

roxblnfk merged 1 commit into
1.xfrom
fix/error-handler-messenger

Conversation

@roxblnfk

Copy link
Copy Markdown
Member

🔍 What was changed

  • Unhandled errors, the Risky reason and the #[WithoutErrorHandler] + #[ExpectErrorHandlerChange] notice now go through Messenger::log() instead of being attached to the returned result.
  • Before, OutputInterceptor replaced the result's messages with its own, so none of them reached a reporter: a warning in a test was visible nowhere.
  • A warning now prints to STDERR as soon as it is raised, at any verbosity, and stays in the test's messages.

Checklist

…he messenger

The plugin attached its messages to the returned result, and the per-test output scope outside it replaced the result's messages with its own, so the warnings, the Risky reason and the opt-out notice never reached any reporter. Logged through the messenger they land in the test's scope and stream live. Refs #430.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
@roxblnfk
roxblnfk requested a review from a team as a code owner November 19, 2026 06:27
@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugin/error-handler/src/ErrorHandlerPlugin.php 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@roxblnfk
roxblnfk merged commit 548a7c8 into 1.x Nov 19, 2026
31 checks passed
@roxblnfk
roxblnfk deleted the fix/error-handler-messenger branch November 19, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant