Skip to content

fix(core): keep messages an interceptor attached to the test result - #437

Merged
roxblnfk merged 1 commit into
1.xfrom
fix/output-interceptor-keep-messages
Nov 19, 2026
Merged

roxblnfk merged 1 commit into
1.xfrom
fix/output-interceptor-keep-messages

Conversation

@roxblnfk

Copy link
Copy Markdown
Member

🔍 What was changed

  • OutputInterceptor no longer replaces the test result's messages with the ones recorded in the messenger scope: both logs are merged in time order, attached messages first on equal timestamps.
  • Before, anything an inner interceptor attached with withMessages() was lost whenever the scope recorded something, which is almost every test because the assert plugin writes the assertion history.

Review notes

  • No duplicates: no producer both logs and attaches the same message, and a nested scope discards its buffer instead of merging it into the parent (checked error-handler, repeat, retry, data provider, JUnit attempts).

Checklist

OutputInterceptor replaced the result's message log with the messages recorded in the test's messenger scope, so anything an inner interceptor attached via `withMessages()` was lost whenever the scope recorded output (the assert plugin writes assertion history for nearly every test). Merge both logs in time order instead, attached messages first on equal time.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
@roxblnfk
roxblnfk requested a review from a team as a code owner November 19, 2026 06:28
@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@roxblnfk
roxblnfk merged commit 3097d72 into 1.x Nov 19, 2026
33 checks passed
@roxblnfk
roxblnfk deleted the fix/output-interceptor-keep-messages branch November 19, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant