Repository navigation
fix(core): keep messages an interceptor attached to the test result - #437
Merged
Merged
Conversation
OutputInterceptor replaced the result's message log with the messages recorded in the test's messenger scope, so anything an inner interceptor attached via `withMessages()` was lost whenever the scope recorded output (the assert plugin writes assertion history for nearly every test). Merge both logs in time order instead, attached messages first on equal time. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
OutputInterceptorno longer replaces the test result's messages with the ones recorded in the messenger scope: both logs are merged in time order, attached messages first on equal timestamps.withMessages()was lost whenever the scope recorded something, which is almost every test because the assert plugin writes the assertion history.Review notes
Checklist