cloning: visibility applies to all properties, readonly is orthogonal - #5854
Merged
lacatoire merged 1 commit intoSep 10, 2026
Merged
Conversation
TimWolla
requested changes
Sep 10, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
This is no longer wrong, but I still find it confusing: Why would it mention readonly for visibility? There is no reason for users to believe that readonly behave any different from other properties visibility-wise (for cloning).
The “Additionally” sentence just repeats the same visibility part again. Of course readonly can only be overridden when you are in the right scope.
The correct claims are:
- Visibility is checked. No ifs.
- Updating readonly properties is legal, even if they are already set on the original object.
lacatoire
force-pushed
the
fix/cloning-visibility-vs-readonly
branch
2 times, most recently
from
September 10, 2026 14:36
4679ece to
d04d1ad
Compare
TimWolla
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
language/oop5/cloning.xml: visibility is checked for all properties (not justreadonly);readonlyis a separate orthogonal constraint