improve attribute formatting with better argument parsing - #256
Merged
Merged
Conversation
jordikroon
force-pushed
the
attribute-constants-v2
branch
2 times, most recently
from
June 22, 2026 19:23
880bae4 to
db7da9a
Compare
This was referenced Jun 22, 2026
Member
|
Looking at the second screenshot for |
jordikroon
force-pushed
the
attribute-constants-v2
branch
3 times, most recently
from
June 24, 2026 06:53
a9c5b3a to
39c4006
Compare
Girgias
reviewed
Jun 27, 2026
| <para>3. Unknown attribute with literal argument</para> | ||
| <classsynopsis class="class"> | ||
| <ooclass> | ||
| <modifier role="attribute">#[\UnknownAttribute(foo: 'bar')]</modifier> |
Member
There was a problem hiding this comment.
What happens if you have an attribute that is not in FQN? A rendering warning?
Member
Author
There was a problem hiding this comment.
It would link silently, like #[\UnknownAttribute]. But I have added a warning as it's not desirable.
Comment on lines
+78
to
+79
| <span class="attribute"><a href="file.knownattribute.is.in.html">#[\KnownAttribute]</a> </span><br> | ||
| <span class="attribute"><a href="file.anotherknownattribute.is.in.html">#[\AnotherKnownAttribute]</a> </span><br> |
Member
There was a problem hiding this comment.
Why is the attribute syntax now in the link? Also space between closing a tag and closing span tag.
Also EOL before EOF on a bunch of files.
Remove trailing whitespace and normalize indentation in test output expectations. Changes are purely formatting corrections to match the expected test output without altering functionality.
jordikroon
force-pushed
the
attribute-constants-v2
branch
from
September 11, 2026 14:26
39c4006 to
4c02ea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #255 with improved rendering.
And