ext/uri: Fix GH-22629 WHATWG validation error incorrect with empty host and non-empty userinfo#22699
Merged
Merged
Conversation
… host and non-empty userinfo The returned error code (LXB_URL_ERROR_TYPE_INVALID_CREDENTIALS) apparently contradicts the specification: "If atSignSeen is true and buffer is the empty string, host-missing validation error, return failure."
kocsismate
force-pushed
the
gh-22629-fix-missing-host
branch
from
98457e0 to
8e3ec77
Compare
kocsismate
commented
Jul 11, 2026
TimWolla
approved these changes
Jul 12, 2026
TimWolla
pushed a commit
to kocsismate/php-src
that referenced
this pull request
Jul 12, 2026
[Tim: Extracted this as a new commit from phpGH-22699]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The returned error code (LXB_URL_ERROR_TYPE_INVALID_CREDENTIALS) apparently contradicts the specification:
"If atSignSeen is true and buffer is the empty string, host-missing validation error, return failure."