ext/soap: Improve SOAP scalar decoding error messages#22706
Open
LamentXU123 wants to merge 2 commits into
Open
ext/soap: Improve SOAP scalar decoding error messages#22706LamentXU123 wants to merge 2 commits into
LamentXU123 wants to merge 2 commits into
Conversation
LamentXU123
force-pushed
the
soap-error-message
branch
from
d1daad1 to
dbadf1a
Compare
devnexen
reviewed
Jul 12, 2026
| return ret; | ||
| } | ||
|
|
||
| static zval *to_zval_base64(zval *ret, encodeTypePtr type, xmlNodePtr data) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext/soap reported many malformed scalar values as the generic:
which is utterly useless, and I don't even know which encoding method has what problem to be fixed.
This PR gives every these vague error message a better version, by at least claim out what is wrong and why.