Fix CTE view parsing across statement delimiters#660
Open
oiahoon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop a CTE view's nested parser at the delimiter that separates it from the next SQL statement. Without this boundary, consecutive unparenthesized
CREATE VIEW ... AS WITH ...statements are parsed as one view and the second statement is appended to the first view's build output.Fixes #639.
Changes
ON DUPLICATE KEY UPDATEscans to the current statement.parseCreateViewAsWithAsparser fixture so it records two top-level statements. The fixture input itself is unchanged.Testing
CreateStatementTestandWithStatementTest: 86 tests, 1,506 assertionscomposer validate --strict --no-check-publishgit diff --checkThe complete local suite has six CLI-only failures because its command strings do not quote this checkout path, which contains a space. The untouched
masterbaseline reproduces the same six failures; all 977 non-CLI tests pass.