Conversation
docs/production-guide.md contradicted itself about --cross-shard-fast-path. Its table and src/config.rs (`default_value = "auto"`) give the default as `auto`, but two prose passages still said "The default is `off`". Those passages were written before moon#777 flipped the default, and nobody updated them afterwards. A reader following the prose would think they are on the SPSC path when they are not. - "The default is `off`" now says `auto`, and names `off` as the rollback. - The moon#768 table is relabelled as the measurement that held the default at `off` before moon#777, with the half-populated-keyspace caveat from the section above. - The "Future" section says the shared-nothing plan (last revised May 2026) predates moon#777, so its "delete the fast path in Phase 3" is a proposal, not a scheduled change. This resolves the residual left open when moon#776's main defect (the flag refusing startup) was fixed by #777. Refs #776 author: Tin Dang
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Warning Review limit reachedNext included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/production-guide.mdcontradicts itself about--cross-shard-fast-path. The table andsrc/config.rs:476(default_value = "auto") say the default isauto. Two prose passages still say "The default isoff": they predate #777, which flipped the default. This is the residual that the #776 triage found after its main defect was fixed.Changes (docs only):
off" now saysauto, and namesoffas the rollback.offbefore perf(shard): serve cross-shard reads under a shared guard (L4 S1-S4) #777. It points to the half-populated-keyspace explanation already in the section..planning/shared-nothing-migration/PLAN.md, last revised 2026-05-14) predates perf(shard): serve cross-shard reads under a shared guard (L4 S1-S4) #777. Its "delete the fast path in Phase 3" step is therefore a proposal, not a scheduled change.Checked: no other passage in
docs/orREADME.mdclaims a default for this flag.Refs #776 (already closed on its main defect).