Fix editable file focus and live syntax highlighting#3979
Draft
jakeleventhal wants to merge 1 commit into
Draft
Conversation
- Persist editor state with stable file cache keys - Preserve annotation identity during unchanged edits - Upgrade the Pierre diffs patch
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@pierre/diffsfrom1.3.0-beta.5to1.3.0-beta.9and carry forward the required editor fixes, including the upstream Pierre editor update from [diffs/edit] Add persisted editor state caching pierrecomputer/pierre#976Root cause
The editable file cache key included the current contents, so every keystroke changed the file identity seen by Pierre and fed the controlled render path back into the active editor. That caused focus loss, hover/text flicker, and comment regressions.
After upgrading Pierre, live retokenization also emitted theme CSS variables that this compiled editor combination did not mount a consumer rule for. Initial file renders were colored, but edited tokens appeared unhighlighted until the file was reopened. The patch now applies the already-resolved active-theme token color directly during the same in-place token update.
User impact
Typing in the editable file pane now retains keyboard focus without the line-hover or text flicker. Review comments continue to work, and syntax highlighting reacts to edits without switching files.
Validation
pnpm exec vp check(0 errors; 9 pre-existing warnings)pnpm exec vp run typecheckpnpm exec vp test apps/web/src/components/files/FilePreviewPanel.test.ts apps/web/src/components/files/fileContentRevision.test.ts(10 tests)pnpm install --frozen-lockfileNote
Fix editable file focus and live syntax highlighting in the file preview panel
@pierre/diffsfrom1.3.0-beta.5to1.3.0-beta.9and replaces the corresponding patch file to pick up upstream editor fixes.projectFileEditorCacheKeyin fileContentRevision.ts to decouple editor identity from file contents, so the editor instance is stable across content changes for the same file path.reconcileFileCommentAnnotationsin fileCommentAnnotations.ts that preserves the existing annotations array reference when annotations are logically unchanged, avoiding unnecessary re-renders.Editorin FilePreviewPanel.tsx withpersistState: trueandpersistStateStorage: 'inMemory'and uses a ref to hold the latest annotations to prevent stale closures.Macroscope summarized b2a771d.