Repository navigation
Support default values for AttributeDefinition. - #312
Merged
Merged
Conversation
AttributeDefinitions previously contained several required fields. However, RFC 7643 Section 2.2 details default values for most fields defined on an AttributeDefinition. To prevent errors from being thrown when such fields are missing from a JSON, the class has been updated to support these default values. This commit includes updated documentation, as well as an update to the toString() method. Previously, toString() manually printed each field value instead of printing the serialized JSON output of the object. Reviewer: dougbulkley Reviewer: vyhhuang JiraIssue: DS-51800
vyhhuang
approved these changes
Aug 14, 2026
vyhhuang
left a comment
vyhhuang
left a comment
Collaborator
There was a problem hiding this comment.
These changes look good to me.
dougbulkley
reviewed
Aug 17, 2026
| did not include the values of `id` and `meta`. | ||
|
|
||
| Updated `AttributeDefinition.java` to use default values for missing definitions as dictated by | ||
| RFC 7643 Section 2.2. For example, if `uniqueness` is missing from a JSON, the AttributeDefinition |
There was a problem hiding this comment.
“missing from a JSON,” doesn’t make grammatical sense.
Collaborator
Author
There was a problem hiding this comment.
Thanks Doug, I've updated this.
dougbulkley
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AttributeDefinitions previously contained several required fields. However, RFC 7643 Section 2.2 details default values for most fields defined on an AttributeDefinition. To prevent errors from being thrown when such fields are missing from a JSON, the class has been updated to support these default values.
This commit includes updated documentation, as well as an update to the toString() method. Previously, toString() manually printed each field value instead of printing the serialized JSON output of the object.
Reviewer: dougbulkley
Reviewer: vyhhuang
JiraIssue: DS-51800
Resolves #309