Skip to content

Fix SLI feedback type #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcaffrey merged 2 commits into from
Aug 7, 2026
+8 −6
Merged

Fix SLI feedback type #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea715a
Fix SLI feedback type
kcaffrey Aug 6, 2026
b65b272
Fix SLI length check
kcaffrey Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions slice_loss_indication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func (p SliceLossIndication) Marshal() ([]byte, error) {

// Unmarshal decodes the SliceLossIndication from binary.
func (p *SliceLossIndication) Unmarshal(rawPacket []byte) error {
if len(rawPacket) < (headerLength + ssrcLength) {
if len(rawPacket) < (headerLength + (ssrcLength * 2)) {
return errPacketTooShort
}

Expand All @@ -76,7 +76,7 @@ func (p *SliceLossIndication) Unmarshal(rawPacket []byte) error {
return errPacketTooShort
}

if header.Type != TypeTransportSpecificFeedback || header.Count != FormatSLI {
if header.Type != TypePayloadSpecificFeedback || header.Count != FormatSLI {
return errWrongType
}

Expand All @@ -103,7 +103,7 @@ func (p *SliceLossIndication) MarshalSize() int {
func (p *SliceLossIndication) Header() Header {
return Header{
Count: FormatSLI,
Type: TypeTransportSpecificFeedback,
Type: TypePayloadSpecificFeedback,
Length: uint16((p.MarshalSize() / 4) - 1), //nolint:gosec // G115
}
}
Expand Down
6 changes: 3 additions & 3 deletions slice_loss_indication_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func TestSliceLossIndicationUnmarshal(t *testing.T) {
Name: "valid",
Data: []byte{
// SliceLossIndication
0x82, 0xcd, 0x0, 0x3,
0x82, 0xce, 0x0, 0x3,
// sender=0x902f9e2e
0x90, 0x2f, 0x9e, 0x2e,
// media=0x902f9e2e
Expand All @@ -39,7 +39,7 @@ func TestSliceLossIndicationUnmarshal(t *testing.T) {
{
Name: "short report",
Data: []byte{
0x81, 0xcd, 0x0, 0x2,
0x81, 0xce, 0x0, 0x2,
// ssrc=0x902f9e2e
0x90, 0x2f, 0x9e, 0x2e,
// report ends early
Expand Down Expand Up @@ -115,7 +115,7 @@ func TestSliceLossIndicationRoundTrip(t *testing.T) {
func TestSliceLossIndicationUnmarshalMaxLength(t *testing.T) {
rawPacket := make([]byte, 4*(0xFFFF+1))
rawPacket[0] = 0x82
rawPacket[1] = 0xcd
rawPacket[1] = 0xce
rawPacket[2] = 0xff
rawPacket[3] = 0xff

Expand Down
2 changes: 2 additions & 0 deletions testdata/fuzz/FuzzUnmarshal/0e87471a44c119a6
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
go test fuzz v1
[]byte("\x82\xce\x00\x010000")
Loading