Filter OBU-padding - #373
Merged
Merged
Conversation
cases chrome to stall
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 87.44% 87.45% +0.01%
==========================================
Files 28 28
Lines 3170 3173 +3
==========================================
+ Hits 2772 2775 +3
Misses 398 398
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ibn-Butt-Toota
approved these changes
Sep 26, 2026
Ibn-Butt-Toota
left a comment
Ibn-Butt-Toota
left a comment
There was a problem hiding this comment.
Amazing catch! Looking forward to the Chrome patch, can you comment the link here once that's in? Thanks :0
Member
Author
|
edit: found that philipp already made a patch https://webrtc-review.googlesource.com/c/src/+/503960 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While i was debugging why chrome is stalling av1 streams in my broadcast box instance it turned out that chrome has a bug with handling obu-paddings (I'm working on sending a patch there + libdatachannel) this won't fix it for bbox since it forwards packets, and it's just work around for users who use rtp depacketizers
related:
Glimesh/broadcast-box#633
bluenviron/mediamtx#5774
bluenviron/mediamtx#6242