Skip to content

fix(pypi): find the repository in the README when project_urls has none #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fleizean merged 2 commits into from
Oct 19, 2026
Merged

fix(pypi): find the repository in the README when project_urls has none #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d74b4f2
fix(pypi): find the repository in the README when project_urls has none
fleizean Oct 19, 2026
ab73709
refactor(pypi): drop the comments on the README repository lookup
fleizean Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/backend/PkgDiff.Infrastructure/Services/PyPIService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,26 @@ private static bool IsGitHubUrl(string? url)
.Concat(links.Where(l => !NotRepositoryKeys.Any(k => l.Key.Contains(k, StringComparison.OrdinalIgnoreCase)))
.Select(l => l.Value));

return candidates.Select(RepositoryRoot).FirstOrDefault(url => url != null);
return candidates.Select(RepositoryRoot).FirstOrDefault(url => url != null)
?? RepositoryFromDescription(info);
}

private static string? RepositoryFromDescription(PyPIPackageInfo info)
{
if (string.IsNullOrEmpty(info.Description) || string.IsNullOrEmpty(info.Name))
return null;

var name = NormalizeName(info.Name);
return System.Text.RegularExpressions.Regex.Matches(info.Description,
@"https?://(?:www\.)?github\.com/[\w.-]+/[\w.-]+",
System.Text.RegularExpressions.RegexOptions.IgnoreCase)
.Select(m => RepositoryRoot(m.Value.TrimEnd('.')))
.FirstOrDefault(url => url != null && NormalizeName(url[(url.LastIndexOf('/') + 1)..]) == name);
}

private static string NormalizeName(string name) =>
System.Text.RegularExpressions.Regex.Replace(name, @"[-_.]+", "-").ToLowerInvariant();

// https://github.com/{owner}/{repo} of a GitHub link (issues, a changelog file, releases), keeping a
// /tree/{ref}/{folder} part that names the package folder of a monorepo; null for any other link
private static string? RepositoryRoot(string? url)
Expand Down Expand Up @@ -245,6 +262,9 @@ private class PyPIPackageInfo

[JsonPropertyName("project_urls")]
public Dictionary<string, string>? ProjectUrls { get; set; }

[JsonPropertyName("description")]
public string? Description { get; set; }
}

private class PyPIReleaseFile
Expand Down