Repository navigation
fix(analysis): categorise notes by their section and stop early only on looked-up versions - #16
Merged
Merged
Conversation
…on looked-up versions Headings such as "BC Breaks:", "#### BC Break" or "### Fixed" now give their category to the lines below them, and a one-off job re-parses the stored notes. The consecutive-empty cutoff no longer counts versions that were never scraped, and GitHub tags spelled parent-, r, v_ or without a -jre/-android variant now match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes found by analysing 7 Packagist and 10 Maven upgrades on production:
Why
monolog/monolog2.9.0 → 3.0.0 anddoctrine/orm2.17.0 → 3.0.0 both list their breaking changes under a heading (Noteworthy BC Breaks:,#### BC Break), yet every one of the 17 comparisons reported 0 breaking changes.AnalyzerServicecategorised each line on its own: a heading never passed its category to the bullets below it, and "BC break" was not a known phrase. Keep-a-Changelog notes (### Fixed,### Added) were all "Other" for the same reason.MaxConsecutiveEmptyVersions(10) stopped the list.phpunit/phpunit10.5.0 → 11.0.0 showed 10 of 67 versions.33.0.0-jreasv33.0.0;r5.11.0, slf4jv_2.0.17;gson-parent-2.11.0, OkHttpparent-4.12.0.Changes
Section headings (
AnalyzerService): a heading sets the category of the lines below it until the next heading. Headings are:#lines;**bold**;:that name a category.A heading that names no category (
### 3.0.0) ends the section; a sentence that merely ends in:does not. Section words: breaking / BC break / incompatible, security, deprecat / removed, bug / fixed, feature / added / new, performance, and neutral ones (changed, contributors, thanks, upgrade, ...) so## New Contributorsis not a feature. A line's own prefix (Fixed: ...) still wins over its section.bc breakis also a line prefix.Stored categories refresh: categories are stored with each note when it is scraped. A new
ReleaseNoteReparseJobruns once at start-up. It compares the newAnalyzer.ParserVersionsetting (default1) withReleaseNoteReparseJob.ParserVersion(2). If they differ, it enqueues one re-parse job per package (one scope each, so no context holds every note) and records the version. Later start-ups are a no-op until the parser version is raised again.Early stop (
PackageAnalysisService.ProcessVersionsAsync):MaxConsecutiveEmptyVersions. Versions never scraped neither count nor reset the run.Tag candidates (
GitHubScraperService):{name}-parent-{v},parent-{v},r{v},v_{v}; the release-suffix fallback also drops-jre/-android.Notes for reviewers
ChangeLog-11.0.md.Checklist
developand is about one thingfeat(scope): ...,fix(scope): ...)src/frontend/src/app/core/models