Repository navigation
fix(ui): make the background grid visible in the light theme - #8
Merged
Merged
Conversation
The grid lines were gray-300 at 40% on white, about #eceef1, which the eye does not pick out. gray-400 at 50% keeps them as faint as the dark theme's while they stay visible. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The background grid behind the public and admin pages is visible in the light theme again.
Why
In the light theme the grid lines were
stroke-gray-300/40: gray-300 (#d1d5db) at 40% on white comes out at about#eceef1, which is practically invisible. In the dark theme the same pattern reads as a faint grid.Changes
grid-pattern.html: light theme strokestroke-gray-300/40→stroke-gray-400/50. The dark theme stroke (dark:stroke-gray-700/30) and the fade masks are unchanged.Notes for reviewers
Four tones were compared side by side on white (gray-300 at 100%, gray-400 at 50% and 70%, gray-500 at 50%); gray-400 at 50% is the closest match to the dark theme's subtlety. The component is used by the public layout and every admin page.
Checklist
developand is about one thingfeat(scope): ...,fix(scope): ...)src/frontend/src/app/core/models