Repository navigation
Sanger Ab1 files support - #136
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
mzueva
force-pushed
the
mzueva/MILAB-7021-ab1-support
branch
from
September 25, 2026 10:39
8706626 to
b9e7578
Compare
Contributor
Author
|
@greptile-apps review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support of tagged ab1 files. Default file names: "{Sample}_{Primer}.ab1"
The PR appears safe to merge; no outstanding findings or accepted new issues remain.
Summary
The PR adds tagged Sanger AB1 datasets, from filename-pattern import through the dataset page to workflow File-column export. The two previously reported issues have been addressed, and their threads are resolved.
TaggedAb1DatasetRecordis a file handle paired with tag values; it is newly introduced for each chromatogram.DSContentTaggedAb1is per-sample AB1 records plus the dataset’s tag names; it is newly added to the dataset-content union.DSTaggedAb1is that content wrapped as a dataset; it is newly exported.FileContentTypeidentifies a file’s format; it now includesAb1.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR A["AB1 filenames"] --> B["Pattern matching"] B --> C["TaggedAb1 records by sample and tag"] C --> D["Dataset page"] C --> E["Workflow File column"]Reviews (2) · Last reviewed commit: "MILAB-7021 Sanger Ab1 files support - re..."