Repository navigation
MILAB-7194: warn about blocks missing data of this block - #137
Open
AStaroverov wants to merge 3 commits into
Open
AStaroverov wants to merge 3 commits into
AStaroverov wants to merge 3 commits into
Conversation
args() builds args from whatever is configured and argsIssues() says what keeps the block from running: a dataset without data and invalid multiplexing rules are reported as issues instead of thrown, so the app sees the block's args while it is still being set up.
AStaroverov
force-pushed
the
MILAB-7194_column-value-refs
branch
from
October 22, 2026 17:56
c4140b4 to
da4c5b5
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The block warns when blocks below it use its data and that data is gone or not produced yet.
ui/src/pages/MetadataPage.vue):<PlBlockDependencies />. It reads the column links the app computes and shows nothing while every link is fine. When another block uses an output this block does not export, values this block no longer has, or data of this block before it has been run, it shows a warning naming those blocks, with advice to add the missing data or run the block; block names open the block.model/src/args_issues.ts): the dataset and multiplexing-rule checks moved from a throw inargs()toargsIssues().args()now always builds args, so blocks below see what this block exports even while it cannot run; every issue is an error, so Run stays disabled exactly when it did before.Depends on milaboratory/platforma#1911:
PlBlockDependenciesand column links exist only in that SDK, so CI passes after its release and an SDK bump here.

Confidence Score: 5/5
No unacknowledged blocking issue was found; merging still depends on the planned SDK release and bump.Summary
Adds warnings when downstream blocks depend on missing data. Moves run checks into
argsIssues()soargs()can still describe the block’s outputs.Important touched types:
ArgsIssue: an SDK issue with a severity and message. Dataset checks now return these instead of throwing.BlockData: the saved datasets, metadata, samples, and import settings. The newblockArgsIssues()helper reads it.BlockArgs: the datasets, metadata, and sample labels sent to the main workflow. Its shape is unchanged; construction no longer throws for validation failures.DSAny: the union of supported dataset types. Its definition is unchanged; validation now returns issues for these datasets.Verification: reviewed source and tests. Tests and UI capture were not run; dependencies are absent and the required UI component awaits the acknowledged SDK release.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD State[Saved block data] --> Args[Build sorted arguments] Args --> Outputs[Describe available outputs] State --> Checks[Check datasets, then multiplexing rules] Checks --> Issues[Return errors through argsIssues] Issues --> Run[Keep Run disabled while errors remain] Links[Links computed by the desktop app] --> Warning[PlBlockDependencies shows missing-data warnings]Reviews (2) · Last reviewed commit: "MILAB-7194: gate Run with argsIssues" · Reviewed by Greptile