Skip to content

Add every file column on metadata import into a project without metadata - #139

Merged
AStaroverov merged 1 commit into
mainfrom
fix/metadata-import-all-columns
Oct 22, 2026
Merged

AStaroverov merged 1 commit into
mainfrom
fix/metadata-import-all-columns

Conversation

@AStaroverov

@AStaroverov AStaroverov commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

What

When a project has no metadata columns yet, the metadata import dialog no longer shows the per-column dropdowns ("Add as a new column / Do not import"). There is nothing to fill, so every column of the file is added as a new metadata column.

Changes

  • ImportMetadataDialog.vue: the column-mapping section (dropdowns and the warnings under them) is shown only when the project already has metadata columns and the mode is "Keep existing columns".
  • "Import information" reads File columns: N (all N added) in this case instead of (N added, 0 filling existing, 0 skipped).
  • Changeset: patch for the block and the UI package.

Note

Without existing columns, the "added under a new name" warning for duplicate headers inside the file is no longer shown; such a column is still added as name (2). Replace mode never showed it either.

Checks

  • pnpm check (ui): passes
  • pnpm test (ui): 82/82
  • Not verified in the desktop app.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

The metadata import dialog now hides column choices when the project has no metadata columns. The import summary says all file columns are added.

  • Metadata imports add every non-sample file column when a project has no metadata.

Important touched terms; no type definitions changed:

  • ImportMode: "keep" | "replace" selects whether existing metadata stays or is replaced. Column choices now appear only for "keep" when metadata already exists.
  • ColumnTarget: selects whether a file column becomes new metadata, fills an existing column, or is ignored. Projects without metadata use the existing new-column defaults without showing these choices.
  • MetadataColumnMapping: maps file-column indexes to ColumnTarget values. This change hides its controls for projects without metadata; the mapping logic stays unchanged.

Reviews (1) · Last reviewed commit: "Add every file column on metadata import..." · Reviewed by Greptile

@AStaroverov
AStaroverov enabled auto-merge October 22, 2026 15:40
@AStaroverov
AStaroverov added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 4175b64 Oct 22, 2026
12 checks passed
@AStaroverov
AStaroverov deleted the fix/metadata-import-all-columns branch October 22, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant