Repository navigation
Add every file column on metadata import into a project without metadata - #139
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a project has no metadata columns yet, the metadata import dialog no longer shows the per-column dropdowns ("Add as a new column / Do not import"). There is nothing to fill, so every column of the file is added as a new metadata column.
Changes
ImportMetadataDialog.vue: the column-mapping section (dropdowns and the warnings under them) is shown only when the project already has metadata columns and the mode is "Keep existing columns".File columns: N (all N added)in this case instead of(N added, 0 filling existing, 0 skipped).Note
Without existing columns, the "added under a new name" warning for duplicate headers inside the file is no longer shown; such a column is still added as
name (2). Replace mode never showed it either.Checks
pnpm check(ui): passespnpm test(ui): 82/82

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
The metadata import dialog now hides column choices when the project has no metadata columns. The import summary says all file columns are added.
Important touched terms; no type definitions changed:
ImportMode:"keep" | "replace"selects whether existing metadata stays or is replaced. Column choices now appear only for"keep"when metadata already exists.ColumnTarget: selects whether a file column becomes new metadata, fills an existing column, or is ignored. Projects without metadata use the existing new-column defaults without showing these choices.MetadataColumnMapping: maps file-column indexes toColumnTargetvalues. This change hides its controls for projects without metadata; the mapping logic stays unchanged.Reviews (1) · Last reviewed commit: "Add every file column on metadata import..." · Reviewed by Greptile