fix: give workflow the same probe grace as icc - #64
Merged
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
changed the title
ivan-tymoshenko
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In hotReload/dev mode the workflow container runs
pnpm installfrom the mounted repo before it binds:3042, which takes well over the previous liveness grace of ~35s (initialDelaySeconds: 5+ 3 ×periodSeconds: 10). The kubelet SIGKILLed the pod mid-install (exit 137) and it fell into CrashLoopBackOff. icc runs the same hot-reload startup but has a ~90s grace and never trips.This aligns the workflow liveness and readiness probes with icc (
initialDelaySeconds: 40,failureThreshold: 5), giving the container enough time to finish installing and start serving/statusbefore the probes begin failing.