Repository navigation
variants: robes' bone copies, cloaks' cloth by the torso, missing bones from the skeleton, cloaks for bodies with none - #106
Merged
Conversation
…missing bones from the skeleton, cloaks for bodies with none Found making Layonara's brownie robes and cloaks: - A robe's bone copies (pelvis_g, torso_g, ...) were moved to the target's joints but kept the source body's size. They are not drawn, but most cast the robe's shadow, and Bioware's race versions reshape them. They are now refitted like a skin vertex weighted wholly to their bone; a bone with no stock body part takes its nearest ancestor's width. Against 56 hand-made brownie robes: 2.0 to 2.2 cm per vertex, from 10 to 11 cm; against Bioware's robes and cloaks of every race (154 pairs): 2.65 cm, from 4.85. - A cloak's cloth on its own bones (Cloak_g and below) kept the source body's size around them: on a brownie the collar stood off the neck. It now takes the torso's width, which replaces widening the cloth by 0.4 of the chest's width ratio. Bioware's cloaks 1 to 7 of every race: 1.8 cm per vertex in phenotype 0 and 4.0 cm in phenotype 2, from 2.9 and 4.7. - A bone the target's template robe lacks (Layonara's brownie robe 3 has no feet; human robe 26 weights its hem to them) is taken from the target's skeleton. Those vertices kept the human body's place, so the hem stayed human-wide, and the robe-on-body preview put the feet below the ground. Feet now take the thighs' width, as shins do. - A body with no cloak at all no longer fails: the source cloak's bones are placed on the target's skeleton (under the neck, as wide as its chest, the hanging chains as long as its neck-to-feet height), with a warning saying so. Over Bioware's cloaks 1 to 7 of every race and phenotype, built this way: 4.2 cm per vertex from Bioware's, against 2.7 cm with Bioware's own cloak of that body as the template. - A variant whose supermodel is its own body (pmb2_cloak_001 -> pmb2) now names the skeleton that body uses: a phenotype with no skeleton of its own uses phenotype 0's, so there was no pmb2 model to find. Stock bodies with their own skeleton (pmh2, pmd2) are unchanged.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while making Layonara's brownie robes and cloaks. Checked in game on brownies: generated robes and cloaks side by side with hand-made and human ones.
pelvis_g,torso_g, ...) were moved to the target's joints but kept the source body's size. They are not drawn, but most cast the robe's shadow, and Bioware's race versions reshape them. They are now refitted like a skin vertex weighted wholly to their bone. A bone with no stock body part takes its nearest ancestor's width.Cloak_gand below) kept the source body's size around them, so on a brownie the collar stood off the neck. It now takes the torso's width. This replaces widening the cloth by 0.4 of the chest's width ratio.--to.pmb0forpmb2, which has no skeleton of its own) instead of a model that does not exist.Mean distance per vertex from the hand-made or Bioware version:
Not fixed: a Large (phenotype 2) brownie's cloak still sits high around the head in game. It was accepted as is, since no one plays one.
Three new tests:
TestVariantRefitsBoneCopies,TestVariantCloakFromSkeletonandTestVariantSuperModelIsTheBodysSkeleton.go test ./...passes. Variants code is not in the Python port.