Repository navigation
Ignore the mesh lightmapped byte and keyword, as the game does - #107
Merged
Merged
Conversation
The game's compiler leaves the lightmapped byte (+500) uninitialised and its ASCII parser reads no lightmapped keyword (nwn-mdl-spec MDL-BIN-051, MDL-ASCII-070). cleanmodels decompiled the garbage byte to a "lightmapped N" line (often 253) and compiled it back. Now the decompiler skips the byte, the writer emits no such line, the parser accepts and ignores the keyword, and the compiler writes 0. Ported to python/.
This was referenced Oct 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The game's compiler leaves the mesh
lightmappedbyte (+500) uninitialised, and its ASCII parser reads nolightmappedkeyword (nwn-mdl-spec MDL-BIN-051, MDL-ASCII-070). cleanmodels decompiled the garbage byte to alightmapped Nline (often 253) and compiled it back.Now:
lightmappedline;center(no warning: every ASCII file older cleanmodels versions wrote has the line);Ported to
python/.Testing (in-game test waived by the user; the game never reads the byte):
go test ./...passes, plusTestLightmappedIgnored: alightmapped 253line changes nothing in the compiled bytes, and nothing is decompiled back.lightmappedlines.